#16680: Use a different curve to test an error message in
EllipticCurve_finite_field.cardinality()
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: task | Status: needs_review
Priority: trivial | Milestone: sage-6.3
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/16680-elliptic_curve_cardinality_doctest|
654c68080b7dad4c976dd1a035c808ab72947c5e
Dependencies: #11474 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:3 tscrim]:
> Continuing from #16158, the question is should the fact that the value
has been computed (and cached) cause a recomputation? Currently how it is
implemented is almost no, but it is always recomputed with
`algorithm='all'`.
If all the algorithms are correct, then I see no reason why we should ever
recompute the order once it has been computed in any way; it is only
useful for debugging purposes.
> I'm somewhat inclined to go with what you say, ignore the `algorithm`
keyword ''always'' once we have computed the cardinality. (Side point, if
we decide to go this route, we should probably switch it to use
`@cached_method` with a key function that ignores the `algorithm`, but for
another ticket.)
>
> However I feel like this could lead to difficult to find bugs, and
instead we should recompute everytime a new algorithm is requested. (In
this case, we could just convert it to a proper `@cached_method`.)
I don't have a strong opinion on this, although using `@cached_method`
would have the advantage that we can get rid of manual caching.
--
Ticket URL: <http://trac.sagemath.org/ticket/16680#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
