#16680: Improve handling of "algorithm" parameter in
EllipticCurve_finite_field.cardinality()
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.3
Component: elliptic curves | Resolution:
Keywords: elliptic curve | Merged in:
cardinality | Reviewers: Travis Scrimshaw,
Authors: Peter Bruin, | Peter Bruin
Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 545410ead180904d6527f0ab54796b1d7e334e43
u/pbruin/16680-elliptic_curve_cardinality_doctest| Stopgaps:
Dependencies: #11474 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
Comment:
Replying to [comment:7 pbruin]:
> Replying to [comment:6 pbruin]:
> > Your doctest will probably fail if the elliptic curve is garbage-
collected between the two invocations.
> Fixed this,
Good point.
> also polished the documentation a bit more and made `heuristic` an
obsolete synonym for `pari`. (`heuristic` just defaulted to `pari`, so
there isn't any real heuristic going on, and "heuristic" may also be
misinterpreted as saying that the result is not guaranteed to be correct.)
I agree since it always went to `pari`. This also leaves the door open for
someone to re-implement this if someone comes up with a proper heuristic.
So positive review. Thanks Peter.
--
Ticket URL: <http://trac.sagemath.org/ticket/16680#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
