#16680: Use a different curve to test an error message in
EllipticCurve_finite_field.cardinality()
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: task | Status: needs_review
Priority: trivial | Milestone: sage-6.3
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/elliptic_curve_cardinality-16680|
e058079e4c09923671b09edf681292d5d82c1903
Dependencies: #11474 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
* branch: u/pbruin/16680-elliptic_curve_cardinality_doctest =>
u/tscrim/elliptic_curve_cardinality-16680
* commit: 654c68080b7dad4c976dd1a035c808ab72947c5e =>
e058079e4c09923671b09edf681292d5d82c1903
Comment:
Well, we can't get rid of the manual cache because of the `cardinality_*`
methods which set it when called (IMO, these should be private methods and
have everything go through `cardinality()` but I don't have a stake in
this).
I've changed it so that `algorithm` is always ignored if the cardinality
is known. If someone wants to check against another algorithm, they can
explicitly call one of the `cardinality_*` methods (which always do the
computation).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=0262f938685351ec0044f0b3e039e2df3a94fd3a
0262f93]||{{{Merge branch
'u/pbruin/16680-elliptic_curve_cardinality_doctest' of
trac.sagemath.org:sage into
u/tscrim/16680-elliptic_curve_cardinality_doctest}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e058079e4c09923671b09edf681292d5d82c1903
e058079]||{{{Made the cardinality ignore the algorithm if known and added
a doctest.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16680#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.