#12212: Colormap for implicit_plot3d and parametric_plot3d
-------------------------------------+-------------------------------------
       Reporter:  niles              |        Owner:  jason, was
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  graphics           |   Resolution:
       Keywords:  colormap, plot     |    Merged in:
        Authors:  Joris              |    Reviewers:
  Vankerschaver, Frédéric Chapoton   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/chapoton/12212   |  1f7fc206043fb1ba781b6355cff553276821edeb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by niles):

 Replying to [comment:46 chapoton]:
 > I have managed (it was a bit painful) to make it work also for implicit
 surfaces. It needs to be doctested, but it works pretty well.

 Great!!  I think there is some codesmell here though, both in duplicated
 code and in the inconsistent interface.  Constant color is a special case
 of color maps, so there shouldn't be a need to treat the two cases
 separately -- in other words, the `global_texture` flag should be
 unnecessary.  In any kind of plot, one can give the `color` argument as a
 string, a tuple, a `Color` object, or perhaps other things -- it makes
 more sense that one should also be able to give the colormap data to that
 argument.  The type of colormap should be determined there (in the
 `Texture` class, or some other unified place) and then handed as a
 `Texture` subclass to `IndexFaceSet`.

--
Ticket URL: <http://trac.sagemath.org/ticket/12212#comment:56>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to