#16879: OA caching in C
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16879 | 3db376f043c01b5ff58e46a845bb69e704c1eacf
Dependencies: #16875 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:28 ncohen]:
> Yo !
>
> > Why `is_available` is in `orthogonal_arrays_find_recursive` instead of
`designs_pyx`? Even if it is `cdef` you can cimport it.
>
> I don't know if it will be inlined in this case. Probably we don't care.
Let's keep it where it is right now. But I am not sure at that point that
we care a C function call.
> > One commit at `public/16879c`... it appears that:
> > - `divisors` is really slow and it is better to do a stupid loop and
check divisibility (might not be True for integer > 1000)
>
> Okay.
>
> > - the kind of loop `for m in [1]+range(min(k,19), 122):` is very
badly cythonized
>
> Perhaps, but your fix is ugly.
It depends where you look at! The C code of the first version was
definitely ugly! Do you have a better idea to make it work?
> What's the problem with only importing the functions when you need them
?
It is slower. An import of an already imported library cost (as you saw
with the move imports from #16875). Not a lot, but repeated it does!
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16879#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
