#16879: OA caching in C
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16879 | cc0e804efc31f83e5be7fcc694416ae4a78114e7
Dependencies: #16875 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
* reviewer: => Vincent Delecroix
Comment:
Replying to [comment:36 ncohen]:
> Yo !
>
> > New review commit at `public/16879c` where
> > - all functions have declaration `cpdef find_XXX(int k, int n):`
>
> Okay. But they are still called "python-style" by
`find_recursive_construction` it seems, for they are stored in a list and
everything.
Right. Unwraping the loop makes it faster... but I am sure you will not
like that ;-)
> > - get rid of the `IntegerListsLex`
>
> Cool ! I added a comment to "remember" what this part of the code does.
>
> > - `//` replaced with `/`
>
> Okay. It produces the very same C code though.
But I put the flag at the top! The problem is that we do not see the
cythonization command.
> > - one occurrence of divisors replaced by a very naive looping
> > (but neither ugly loops anymore nor moved import)
>
> Okayyyyy !
>
> > If you like the review commit at `public/16879c` you can set to
positive review.
>
Let us go and play with something else. We will come back to that kind of
optimization later when we will care about `MOLS_table(200)`...
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16879#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
