#16879: OA caching in C
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16879 | 3db376f043c01b5ff58e46a845bb69e704c1eacf
Dependencies: #16875 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:30 ncohen]:
> > It depends where you look at! The C code of the first version was
definitely ugly! Do you have a better idea to make it work?
>
> I look at the code I work with. I agree that it may be nice to improve
it, but not at that cost, this is ugly.
I understand, but there is really something to improve here... no problem
to remove my modifications but then what?
> > > What's the problem with only importing the functions when you need
them ?
> >
> > It is slower. An import of an already imported library cost (as you
saw with the move imports from #16875). Not a lot, but repeated it does!
>
> Show me the cost of those or leave the code as it is.
A very big cost, indeed!! I split the commits into two. The second one is
about imports. The following timings refer to %time MOLS_table(60)
- with the head at 093ace3 (with the imports as you did): 12.9 s
- with the head at 680d22b (with the import on top): 12.7 s
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16879#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
