#16879: OA caching in C
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16879 | 3db376f043c01b5ff58e46a845bb69e704c1eacf
Dependencies: #16875 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_info => needs_review
Comment:
Yo !
> New review commit at `public/16879c` where
> - all functions have declaration `cpdef find_XXX(int k, int n):`
Okay. But they are still called "python-style" by
`find_recursive_construction` it seems, for they are stored in a list and
everything.
> - get rid of the `IntegerListsLex`
Cool ! I added a comment to "remember" what this part of the code does.
> - `//` replaced with `/`
Okay. It produces the very same C code though.
> - one occurrence of divisors replaced by a very naive looping
> (but neither ugly loops anymore nor moved import)
Okayyyyy !
> If you like the review commit at `public/16879c` you can set to positive
review.
I added a small commit on top. I have to write an
`is_quasi_difference_matrix` function but I don't enjoy it very much `T_T`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16879#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
