#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 40d4cfaa662913ca6795a8a9a598b53cf931809c
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:36 tscrim]:
> I know this will sound snarky/condescending, but I do honestly mean it.
You should probably learn more git in order to be a better reviewer.
You should also learn git to become a better contributor! The reviewer is
doing a kind of sacrifice, so there is no way to discuss that the effort
should be done from the contributor side (of course ignore that for first
contributions).
> There is a good reason to merge the latest develop version, you never
know what exactly has changed. Unless you're relying only on python (which
I highly doubt is the case), you can get into subtle changes which can
break your program (for example, output format was changed from a list
into a tuple; I've been bitten by this).
Right. For me a doctest issue is also a merge conflict but not in the git
sense. There are also a good reason to not do it: keep the history clean.
> For the most part I don't look at the commit history when reviewing a
ticket, instead I look at the overall diff from develop/dependencies.
Afterwards if additional changes are made, then it's commits, but I'd
rather see the forest than tree by tree.
The history is good to help the reviewer understands what the
modifications provided by a branch does. You are of course allowed to
ignore that. I really think that I am a git person and you are the hg
person if you work that way. A global diff can be really ugly even if the
commits are very nice (just have a look at #16884).
> Again, commits are not the patches of Hg.
Hum, each commit is a diff and a patch is a diff. So technically speaking
they are. Now, if you want to argue about the philosophy of what a commit
should be and what a patch should be it has nothing to do with the
softwares but how you use them... and you are free to use them the way you
want!
By the way, I would like to stop that discussion on the ticket as it
spoils the Game theory purpose of it!
Best,
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
