#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
       Reporter:  vinceknight        |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  game theory        |   Resolution:
       Keywords:  Game Theory,       |    Merged in:
  Matching Games,                    |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  40d4cfaa662913ca6795a8a9a598b53cf931809c
  
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|  
   Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:32 kcrisman]:
 > I want to say that in this case it ''does'' make sense to have a lot of
 commits for two reasons:

 I should not have complained by the number of commits but rather about the
 number of useless commits.

 >  * Implementing from scratch this functionality, like for sage-matroid

 Sage-matroids was about 10K lines of code!

 >  * Two different authors, and ideally one wants to keep their
 contributions clear

 +1. To each commit is associated an author and we really do not want to
 fusion commits from different authors.

 > But again, my main concern is just that I am not git wizard enough to
 view the appropriate changes.  It sounds like one will want to start from
 (say) the latest beta release and add the relevant code here.  (That's
 good, because the original directory src/sage/game_theory/all.py is
 already in, I believe.)

 At least we end up to the same conclusion: the branch linked to a simple
 ticket should be simple enough to have a clear view on what have changed.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to