#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 40d4cfaa662913ca6795a8a9a598b53cf931809c
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
> I want to say that in this case it ''does'' make sense to have a lot of
commits for two reasons:
> * Implementing from scratch this functionality, like for sage-matroid
> * Two different authors, and ideally one wants to keep their
contributions clear
If I understand correctly what Vincent says, he means that the history of
a git branch should be made to ease the reviewer's job.
The reviewer wants to check that everything does its job and is
implemented correctly. It does not help if what is done in one commit is
undone in the next. What can help him is when each commit has a clearly
defined task and does it well. That way the branch is easier to review.
What you do on your own computer is your own affair, but when you push to
a public branch linked to a ticket you are already 'sharing' code, and it
is better if the code you share is meant to be read.
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
