#15820: Implement sequences of bounded integers
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  sequence bounded   |    Merged in:
  integer                            |    Reviewers:
        Authors:  Simon King         |  Work issues:  memory corruption
Report Upstream:  N/A                |       Commit:
         Branch:                     |  f20dc096832f260edee2f28b3007bf42263f54ac
  u/SimonKing/ticket/15820           |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by SimonKing):

 * status:  needs_work => needs_review


Comment:

 In the new commit, I added assertions to make sure that I am not writing
 into non-allocated memory. So, the code should now be water proof in that
 regard.

 All tests pass, including the "stress test". So, it can be reviewed now!

 Question to the reviewer: Can the assertions be removed? After all, what
 is being asserted is just that some variables are correctly computed, but
 this can in principle be checked by reading the code. Or are assertions
 (even in relatively tight loops) cheap enough?

--
Ticket URL: <http://trac.sagemath.org/ticket/15820#comment:134>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to