#16934: Fix factory keys for finite fields to avoid repeated construction
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: finite rings | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/16934 | 33c86ef572ea686782d5167d58c29a7e0b2d1f6c
Dependencies: #16930 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
* commit: ffb74fa8116d1a60e255300370ca4467e3b36732 =>
33c86ef572ea686782d5167d58c29a7e0b2d1f6c
Comment:
Please restore the warning
{{{
warn("the 'modulus' argument is ignored when constructing prime finite
fields")
}}}
for all prime finite field implementations because the modulus really is
ignored:
{{{
sage: x = polygen(GF(7)); GF(7, modulus=x-2, impl="givaro").modulus()
x + 6
}}}
Of course we could change that behaviour (perhaps we should), but let's do
that on a new ticket.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=33c86ef572ea686782d5167d58c29a7e0b2d1f6c
33c86ef]||{{{Merge remote-tracking branch 'origin/develop' into
ticket/16934}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16934#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
