#16934: Fix factory keys for finite fields to avoid repeated construction
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: finite rings | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/16934-FiniteField_factory_key|
bf36ec118ee0c97dbfae0aed177c1014430b7a07
Dependencies: #16930 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:22 pbruin]:
> This commit adds back the warning. Alternatively, it could have been
put outside the `if impl == 'modn'`, but in this way it is easier to
remove again for non-`modn` implementations.
I would prefer to have the warning in one place. If we every allow a
custom modulus, we should allow it for all implementations.
My vision for this "modulus" argument is that the following should assign
to `a` a primitive root:
{{{
sage: K.<a> = GF(7, modulus='primitive')
}}}
so perhaps we should expand the warning to say
{{{
warn("currently, the 'modulus' argument is ignored when constructing prime
finite fields. This might change in the future and this will probably also
change the output of the .gen() and .modulus() methods on the finite
field.\nSee http://trac.sagemath.org/16934 for details.")
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/16934#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
