#16934: Fix factory keys for finite fields to avoid repeated construction
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: finite rings | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/16934-FiniteField_factory_key|
bf36ec118ee0c97dbfae0aed177c1014430b7a07
Dependencies: #16930 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
{{{
sage: GF(7, impl="givaro", modulus="primitive")
---------------------------------------------------------------------------
AttributeError Traceback (most recent call
last)
<ipython-input-2-c6a1d2461111> in <module>()
----> 1 GF(Integer(7), impl="givaro", modulus="primitive")
/usr/local/src/sage-git/local/lib/python2.7/site-
packages/sage/structure/factory.so in
sage.structure.factory.UniqueFactory.__call__
(build/cythonized/sage/structure/factory.c:1160)()
/usr/local/src/sage-git/local/lib/python2.7/site-
packages/sage/rings/finite_rings/constructor.pyc in
create_key_and_extra_args(self, order, name, modulus, names, impl, proof,
check_irreducible, **kwds)
521 if not modulus.is_irreducible():
522 raise ValueError("finite field modulus must be
irreducible but it is not.")
--> 523 if modulus is not None and modulus.degree() != n:
524 raise ValueError("the degree of the modulus does
not equal the degree of the field.")
525
AttributeError: 'str' object has no attribute 'degree'
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/16934#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
