#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 197c9ae815c4753b5fc3681b1d1a651667289ecc
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
I asked about the gambit stuff because the spkg data is a part of the
branch.
For the `__eq__` of `Player`, I would rewrite this as
{{{#!python
if isinstance(other, Player):
return self.name == other.name
return self.name == other
}}}
This is faster in general if `name` is some "horrible" object with a
(relatively) hard to compute `repr` but easy equality testing (most Sage
parents fall into this category due to `EqualityById`). It should be on
the same order of speed and is less fragile (I believe there are objects
in Sage with the same string repr but different hashes).
The `import all` was in `gametheory` (although it is in the
`game_theory/__init__.py` because I didn't check there when looking at the
initial ticket).
It's probably overkill to have `Player` inherit from `SageObject`; just
the python `object` should be sufficient.
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:70>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
