#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: enhancement | Status: closed
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution: fixed
Keywords: flint, matrix | Merged in:
Authors: Marc Masdeu | Reviewers: William Stein, Jeroen
Report Upstream: N/A | Demeyer
Branch: | Work issues:
812a5099731dd5e819ebce0b19ee744de439a6ea| Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:92 mmasdeu]:
> I must say that IMO some of the comments (82 and 90) made above are not
very constructive.
[comment:82] was made out of frustration by seeing so many things here
which are dubious. So okay, that's not constructive.
However in [comment:90], I noticed a mistake, mentioned it in the comment
and fixed it in #17090. How is that not constructive?
> while clearly he himself didn't read the comments at the beginning of
the ticket (at least those that refer to the convenience of leaving in the
legacy functions).
That's true, but after William Stein's comment, I have fixed that back in
#17090.
> I feel less inclined to take on the analogous job for
matrix_rational_dense.
Please don't. I think it's absolutely good to improve matrices like you
did here. The fact that I am making so many comments and creating follow-
up tickets means that I care. I make mistakes, you make mistakes, that's
normal and that's why have this review process.
My only complaint (and I still stand behind this) is that this ticket was
given positive_review too soon. Ideally, those 3 follow-up tickets should
have been reviewer patches on this ticket.
--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:93>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
