#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: enhancement | Status: closed
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution: fixed
Keywords: flint, matrix | Merged in:
Authors: Marc Masdeu | Reviewers: William Stein, Jeroen
Report Upstream: N/A | Demeyer
Branch: | Work issues:
812a5099731dd5e819ebce0b19ee744de439a6ea| Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:94 mmasdeu]:
> Also, if there are other things that are dubious please share them
because I (and possibly others!) would like to learn from it.
Well, you can look at the follow-up tickets #17090 and #17094 and see what
I changed (and preferably review those tickets).
Some general things which haven't been mentioned yet:
1. clean-up your code when you change things: when you remove code, try to
remove everything related to the old code. When you change code, the old
structure might not be applicable anymore, so refactor if needed (e.g. the
sepatate branch for `n <= 4` in `determinant()` no longer serves any
purpose)
2. also fix documentation: when you change something, also change the
corresponding documentation. When you copy/paste something, be sure to
update documentation and doctests (see the various `set_unsafe` methods).
3. don't add unneeded import statements or includes, those add needless
extra dependencies. Like, why did you add `include
"sage/libs/ntl/decl.pxi"` in several places when you don't use any NTL
code?
4. try to use correct formatting: spacing, indentation, docstring
formatting (this was mostly good, but a bit messed up in
`src/module_list.py`). If anything, this makes your code look more
professional and less sloppy.
5. don't use `assert` for checking user input: use `assert` for when you
''know'' that something is true (but want to check just in case), not when
you need to check that something is true.
--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:97>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
