#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: enhancement | Status: closed
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution: fixed
Keywords: flint, matrix | Merged in:
Authors: Marc Masdeu | Reviewers: William Stein, Jeroen
Report Upstream: N/A | Demeyer
Branch: | Work issues:
812a5099731dd5e819ebce0b19ee744de439a6ea| Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mmasdeu):
Replying to [comment:93 jdemeyer]:
> [comment:82] was made out of frustration by seeing so many things here
which are dubious. So okay, that's not constructive.
I can understand your frustration. But the bar is high enough (python +
cython + sage oddities + legacy code + git + trac, and I am probably
missing something here) that makes it very hard for people to contribute,
and these comments do not help. But I take your last comment in good faith
:-).
Also, if there are other things that are dubious please share them because
I (and possibly others!) would like to learn from it.
> However in [comment:90], I noticed a mistake, mentioned it in the
comment and fixed it in #17090. How is that not constructive?
Surely I did not go and touch p-adics for no reason. These changes weren't
there in the first version of the my patch, and I had to add them because
during the time it took to from the first version until this ticket got
closed other changes were being merged, and these made the patch to stop
compiling. Changing those lines in p-adics is how I managed to fix it, but
the hackish idea was not mine, I saw it used elsewhere. I appreciate you
having fixed it back.
--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:94>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
