#17108: IncidenceStructure.degree(set={1,2,3})
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ncohen/17108     |  c34fda620e898708392becbbf8994d9065e29371
   Dependencies:  #17104             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Hey,

 {{{
 + if int(p is None)+int(set is None)+int(sets_of_size is None) <2:
 +    raise ValueError("Only one parameter must be defined"
 }}}
 wouldn't `>1` be more appropriate? (I note that you used a `ValueError`
 and not an assert ;-)

 Hum
 {{{
 + if set is not None:
 +     # getting the 'set' function back
 +     set_of_points = set
 +     from __builtin__ import set
 }}}
 looks like another argument name would be better... `points`? `pts`?

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/17108#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to