#17135: Compute diameter using 2sweep, 4sweep and iFUB
-------------------------+-------------------------------------------------
Reporter: | Owner:
dcoudert | Status: needs_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: David | 299c32364d6c928e4db9ee43ce17211f744b86ef
Coudert | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dcoudert/help |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Hello again !
Okay, I finally understood how this thing works and it is quite simple and
clear. Cool !
Aaaaaand so I added a paragraph of doc that explains how the algorithm
works.
I also replace a couple of 4sweeps->multisweep, and remove the references
from `GenericGraph.diameter` as Sphinx complained of having them twice as
they are in `distances_all_pairs` too.
Now, while I updated the doc of `distances_all_pairs.diameter` I did not
update the doc of `GenericGraph.diameter` because I have a question: why
on earth do we define `GenericGraph.diameter` instead of just importing
into `GenericGraph` the function from `distances_all_pairs` ? All the
documentation is mostly a copy/paste !?
Also in multi-sweep/diameter_iFUB: the documentation says that the `int *`
store the result of a BFS from `source`, while actually not much can be
claimed about their content when the function returns. Just say that it is
memory space used by the function while it runs unless you can say
something more ?..
I added a commit with my changes at public/17135, tell me what you think !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17135#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
