#17135: Compute diameter using 2sweep, 4sweep and iFUB
-------------------------+-------------------------------------------------
Reporter: | Owner:
dcoudert | Status: needs_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: David | 69cb552df487c204e8590a9421e44c044983f8c0
Coudert | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dcoudert/help |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Hello !
> Following your comments, I'm now importing the new method as
{{{GenericGraph.diameter}}}.
> I have also removed some {{{int *}}} parameters from iFUB and multi-
sweep. It avoids confusion. Also, since we only need to allocate tables
(no need to initialize them), the extra cost of allocating some tables in
2 different methods is negligible.
Well.
1) Looks ready to go
2) Good job
3) Thanks for this patch !
> PS: git is powerful but not intuitive/easy for non experts.
Yep. Contributing to Sage is really hard at first `:-/`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17135#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
