#11912: Clarify simplify_radical and Maxima's radcan
-------------------------------------+-------------------------------------
Reporter: kcrisman | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: documentation | Resolution:
Keywords: sd48 | Merged in:
Authors: Michael Orlitzky | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mjo/ticket/11912 | 2d50b886561b9cc98585749b6292eaba269da73c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mjo):
I just pushed another commit adding the example from #3520. I'm against
adding ``canonicalize_exp`` and ``canonicalize_log`` methods, since they
don't seem to serve a purpose and can cause bugs. For example, see the
change I made in relation.py:
{{{
#Try to apply some simplifications to see if left - right == 0
- simp_list = [difference.simplify_log, difference.simplify_rational,
difference.simplify_exp,difference.simplify_radical,difference.simplify_trig]
+ simp_list = [difference.simplify_log,
difference.simplify_rational,difference.canonicalize_radical,difference.simplify_trig]
}}}
Both `simplify_exp` and `simplify_radical` were being called, wasting
cycles, because they're the same thing!
I can see the benefit for things like `full_simplify()` where we're
mimicking the Mathematica name so that new users can find it through tab
completion. But for `canonicalize_*` I don't think it's going to do us any
good.
I agree that ideally this and #14630 should have some kind of dependency,
but practically, they both may sit around waiting for review for a while.
I'd rather not put up roadblocks to either one getting reviewed; when one
of them gets in, I'll go update the other branch.
--
Ticket URL: <http://trac.sagemath.org/ticket/11912#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
