#11912: Clarify simplify_radical and Maxima's radcan
-------------------------------------+-------------------------------------
Reporter: kcrisman | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: documentation | Resolution:
Keywords: sd48 | Merged in:
Authors: Michael Orlitzky | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mjo/ticket/11912 | e5ab33994355520f0f27914f73f1680292eadc3d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mjo):
Replying to [comment:23 kcrisman]:
> In `def simplify`,
> {{{
> .. seealso::
>
> :meth:`simplify_full`, :meth:`simplify_trig`,
> :meth:`simplify_rational`, :meth:`simplify_factorial`,
> :meth:`simplify_log`
> }}}
> You just removed it here rather than replacing it; intentional or not?
It's still useful, could put a reference in.
[[BR]]
Intentional, since it's no longer a `simplify_*` method. But I'm fine with
having it listed there.
[[BR]]
> (For that matter, we also now have several ''other'' `simplify_foo`
methods which should be added to the lists of simplifications in a few
places.)
[[BR]]
I'm happy to add these. I've been meaning to add `simplify_rectform()` to
`simplify_full()` once I stop making changes all over expression.pyx.
Maybe in that ticket, or #14630 is probably where it's most appropriate
since it adds yet another `simplify_*` method.
[[BR]]
> {{{#!diff
> # Add elementwise methods.
> for method in ['simplify', 'simplify_exp', 'simplify_factorial',
> 'simplify_log', 'simplify_radical', 'simplify_rational',
> - 'simplify_trig', 'simplify_full', 'trig_expand',
'trig_reduce']:
> + 'simplify_trig', 'simplify_full', 'trig_expand',
> + 'canonicalize_radical', 'trig_reduce']:
> setattr(Vector_symbolic_dense, method,
apply_map(getattr(Expression, method)))
> }}}
> Why is this keeping `simplify_radical`?
[[BR]]
That code is adding methods to a class -- if we remove `simplify_radical`
entirely, it will break code that attempts to call `simplify_radical` on a
vector. Instead I leave it there to throw the deprecation warning.
--
Ticket URL: <http://trac.sagemath.org/ticket/11912#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
