#11912: Clarify simplify_radical and Maxima's radcan
-------------------------------------+-------------------------------------
       Reporter:  kcrisman           |        Owner:  mvngu
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  documentation      |   Resolution:
       Keywords:  sd48               |    Merged in:
        Authors:  Michael Orlitzky   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mjo/ticket/11912                 |  e5ab33994355520f0f27914f73f1680292eadc3d
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by kcrisman):

 In `def simplify`,
 {{{
         .. seealso::

            :meth:`simplify_full`, :meth:`simplify_trig`,
            :meth:`simplify_rational`, :meth:`simplify_factorial`,
            :meth:`simplify_log`
 }}}
 You just removed it here rather than replacing it; intentional or not?
 It's still useful, could put a reference in.

 (For that matter, we also now have several ''other'' `simplify_foo`
 methods which should be added to the lists of simplifications in a few
 places.)

 {{{#!diff
  # Add elementwise methods.
  for method in ['simplify', 'simplify_exp', 'simplify_factorial',
          'simplify_log', 'simplify_radical', 'simplify_rational',
 -        'simplify_trig', 'simplify_full', 'trig_expand', 'trig_reduce']:
 +        'simplify_trig', 'simplify_full', 'trig_expand',
 +        'canonicalize_radical', 'trig_reduce']:
      setattr(Vector_symbolic_dense, method, apply_map(getattr(Expression,
 method)))
 }}}
 Why is this keeping `simplify_radical`?

 > Maybe you just have to think of the complex square root in terms of the
 complex exponential and logarithm, at which point it becomes OK for
 canonicalize_radical() to affect certain log/exp expressions?
 Sure!  But I mean that the name, if anything, is more about exp/log then
 as opposed to radicals.  Just seems curious, and wondering whether a
 better name is possible.  It may not be.

--
Ticket URL: <http://trac.sagemath.org/ticket/11912#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to