#17449: deprecate/remove Graph.to_partition and Poset.to_graph
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.5
defect | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | a8822900d5d9e428f4fd92d52ed9d00840ef61df
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/17449 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> I've stated it before, I believe putting things into the documentation
is sufficient and having a method `to_graph` says there is a "natural"
conversion to a graph through considering a Poset as a directed graph. So
if you want to rename it, don't expect me to put it the work to find a
"better" name. It doesn't hurt anyone by being there (with good
documentation).
Travis, please be fair with us. You believed yourself until Vincent's
comment that the function returned a digraph while it returns a graph. You
see how confusing it can be. Also it is incorrect to say that there is a
"natural" conversion to graph: there is none, because there are many ways
to obtain a graph/digraph. None is canonical.
Furthermore, we want to remove `to_graph` because properly named methods
already exist:
{{{
sage: p = Poset()
sage: p.incomparability_graph()
Incomparability graph on 0 vertices
sage: p.hasse_diagram()
Digraph on 0 vertices
}}}
Why would we keep a misnamed function when we already have two which do
the job right ?
We can already see that a Poset can be converted into a graph from the
list of Poset methods. And a non-expert user who would miss
`.hase_diagram` (because it does not contain the word 'graph') will not
miss `incomparability_graph`.
With all this, I am sorry that I do not understand why you would want to
keep this `to_graph` function.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17449#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
