#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
       Reporter:  aschilling         |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  blocker            |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  days64             |    Merged in:
        Authors:  Bryan Gillespie,   |    Reviewers:
  Anne Schilling, Nicolas M. Thiery  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  0c5305c958517701a68b4419f8a173f544cbefd4
  public/ticket/17979                |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Replying to [comment:136 jdemeyer]:
 > Replace
 > {{{
 > raise ValueError("The specified parameters do not allow for a
 lexicographic iterator!")
 > }}}
 > by
 > {{{
 > raise RuntimeError("the specified parameters do not allow for a
 lexicographic iterator")
 > }}}

 Really? RuntimeError is "for an error that doesn’t fall in any of the
 other categories", where as we do fit within the ValueError category:
 "when a built-in operation or function receives an argument that has
 the right type but an inappropriate value". Here IntegerListsLex did
 receive inappropriate value which makes the lexicographic enumeration
 improper.

 Nicolas

--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:161>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to