#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers:
Anne Schilling, Nicolas M. Thiery | Work issues:
Report Upstream: N/A | Commit:
Branch: | 46d01a95002b3b498c9af1ed6784fa0fd4960ae5
public/ticket/17979 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:161 nthiery]:
> Replying to [comment:136 jdemeyer]:
> > Replace
> > {{{
> > raise ValueError("The specified parameters do not allow for a
lexicographic iterator!")
> > }}}
> > by
> > {{{
> > raise RuntimeError("the specified parameters do not allow for a
lexicographic iterator")
> > }}}
>
> Really? `RuntimeError` is "for an error that doesn’t fall in any of the
> other categories", where as we do fit within the `ValueError` category:
> "when a built-in operation or function receives an argument that has
> the right type but an inappropriate value". Here `IntegerListsLex` did
> receive inappropriate value which makes the lexicographic enumeration
> improper.
Fine, I don't care so much (but there is also the formatting issue of not
using a capital letter and exclamation mark). I felt that `RuntimeError`
was more appropriate because it is not really a specific value which is
bad, but some computation based on the input values from which it can be
concluded that the input is bad.
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:169>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
