#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers:
Anne Schilling, Nicolas M. Thiery | Work issues:
Report Upstream: N/A | Commit:
Branch: | f73c43fd4423675f9ce279da9bb929a44db31483
public/ticket/17979 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by nthiery):
* status: needs_work => needs_review
Old description:
> As documented in #17548, #17956, #17920, there are several bugs in
> !IntegerListsLex which also have implications for !Partitions and
> !Compositions. This branch reimplements !IntegerListsLex.
>
> See also #18055 and #18056 for followups.
>
> Remaining design points:
>
> - Do we want to keep the feature that after `min_length`, lists are
> "considered up to trailing zeroes".
> - Renaming all the attributes (`.floor`, ...) to private attributes
> - Double check to logic for improper lexicographic iterability detection
New description:
As documented in #17548, #17956, #17920, there are several bugs in
!IntegerListsLex which also have implications for !Partitions and
!Compositions. This branch reimplements !IntegerListsLex.
See also #18055 and #18056 for followups.
Remaining design points:
- Renaming all the attributes (`.floor`, ...) to private attributes
- Double check to logic for improper lexicographic iterability detection
--
Comment:
Ok, I believe all the points that have been raised have been catered
for (but some may have slipped through in this long thread). So this
is up for formal review.
Thanks for all the comments and suggestions!
Note: please see the description where I left two points where
feedback is specifically welcome.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=9bf94c4bc04b84dec35af83bb4962e5bbaf24523
9bf94c4]||{{{17979: moved min_sum and max_sum later in the __init__
arguments}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f73c43fd4423675f9ce279da9bb929a44db31483
f73c43f]||{{{17979: trivial doctest fix}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:178>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
