#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 6de41768a385f5742dd72eed35746cd5ca22afc9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: Nathann Cohen, Jeroen Demeyer => Nathann Cohen, Jeroen
Demeyer, Travis Scrimshaw
Comment:
Here are my comments on the current state of things:
- In `integer_list.py`:
- I don't understand this sentence in the header: "It was then
completely rewritten in 2015 by Gillespie, Schilling, and Thiery, with the
help of many, to catter for limitations and lack of robustness w.r.t.
input." I think by "catter" you mean "cater", but that isn't correct usage
of the word.
- "dyck words" capitalization.
- I don't like the fact that when the answer is known to be infinite,
that the category is `FiniteEnumeratedSets`.
- You should test also when the input `n` is a tuple.
- In `_check_lexicographic_iterable`, "Checks" should be "Check"
- In `tutorial.py`, {{{predict when a sequence `\ell_0,\dot,\ell_k` is a
prefix of some}}}, it should be "\dots".
- In `integer_vector.py`
- Use absolute paths instead of relative paths: `from combinat import
CombinatorialClass`
- In `list2func`, could we code-afy the doc?
- In the `__init__`, this is missing the double-colon: "All the
attributes below are private; don't use them!"
- Could we split the long line in the `_repr_`?
- Should we formally deprecate the `next` method?
- In the error message "If k is a list, no optional argument is
supported", let's make it lowercase.
Otherwise I'm okay with how the code looks (but I did not run tests like
Jeroen).
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:248>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
