#18078: CMake optional package
-------------------------------------+-------------------------------------
       Reporter:  isuruf             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Isuru Fernando     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  72a020d1f2628dd7fc7595b9cf0485a14d6fb426
  u/isuruf/cmake_optional_package    |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by isuruf):

 Replying to [comment:9 jdemeyer]:
 > Replying to [comment:7 dimpase]:
 > > The installation works on Linux, at least. How does one check it is
 not broken?
 >
 > `cmake` has a test-suite run with `make test`. So a `spkg-check` file
 should be added to run this.

 `cmake` has a test suite that can be run using `ctest`. I wrote a `spkg-
 check` and ran the tests on Linux. 3/382 tests fail, two of which is
 related to curl, and the other about a sleep command. I'm not sure whether
 these options will be required by packages in the future.
 23 - curl (Failed)
 178 - CTestTestUpload (Failed)
 218 - CTestTestStopTime (Failed)

 >
 > One more remark: you don't really need to split up `$MAKE` and `$MAKE
 install` in two steps, just `$MAKE install` is sufficient.

 Thanks. I will make this change.

--
Ticket URL: <http://trac.sagemath.org/ticket/18078#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to