#6441: [with patch, needs work] Charpoly (plus adjoint and det)
--------------------------------------------+-------------------------------
Reporter: spancratz | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: linear algebra | Keywords: charpoly,
division-free
Reviewer: Rob Beezer, Yann Laigle-Chapuy | Author: Sebastian Pancratz
Merged: |
--------------------------------------------+-------------------------------
Changes (by rbeezer):
* reviewer: => Rob Beezer, Yann Laigle-Chapuy
Comment:
Sebstian,
Very good! Builds cleanly and passes all tests. I got two warnings
building the documentation, I think these were leftovers from the
discussion above. I've attached a patch that fixes both.
So this is a positive review, though you need to accept my changes in the
documentation patch. If the changes look OK, then change the subject line
to {{{[with patch, positive review]}}} and then it'll get merged into the
next release.
This will be a great addition to Sage. Thanks for your patience with all
the details. Your next patch should be a whole lot easier.
Release manager: Apply the two patches from 2009/08/28 (version 3), first
the "a_rings" and then the "b_df_charpoly", then the reviewer patch.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6441#comment:30>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---