#6441: [with patch, needs work] Charpoly (plus adjoint and det)
----------------------------+-----------------------------------------------
Reporter: spancratz | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: linear algebra | Keywords: charpoly, division-free
Reviewer: | Author: Sebastian Pancratz
Merged: |
----------------------------+-----------------------------------------------
Comment(by rbeezer):
Hi Sebastian,
Working in batches - this is just about {{{is_field()}}} and friends.
1. In {{{sage/algebras/group_algebra.py}}} you have
{{{self.base_ring.is_integral()}}} which needs to be completed to
{{{.is_integral_domain()}}}.
2. Patch attached - it has a doctest for {{{is_field}}} in
{{{sage/rings/ring.pyx}}} to illustrate the {{{proof}}} parameter in
action (which I think should be illustrated at least once). You'll
recognize it from your sage-devel post. Do you have something similar
that would work well for {{{is_integral_domain()}}}?
3. When I applied the patch a colon was missing in
{{{sage/rings/quotient_ring.py}}} after a {{{try}}}. No idea why - since
the colon is in your patch. But I fixed it by hand, and so its in my
attached patch, along with the fix for (1) above. So you might just cut
out the doctest by hand to build it in rather than applying the patch.
I'll look at part (b) in the next couple of days.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6441#comment:23>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
