#19136: NO and NU graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 2bd5f54053f39da78f3c610ee009f6f8bf89a440
Report Upstream: N/A | Stopgaps:
Branch: |
u/dimpase/NONU |
Dependencies: |
#19098, #19180 |
-------------------------+-------------------------------------------------
Changes (by dimpase):
* reviewer: Nathann Cohen =>
Comment:
Replying to [comment:22 ncohen]:
> > Unfortunately I did not record this as two separate commits, and I
don't see how I could change this now without much effort...
>
> How do you think I should review this ticket, then? Re-review
everything?
Splitting a file into two isn't really specially supported by git, no?
That is, in the new file one can potentially put anything..
%%% while I was writing this I saw your review, thanks! anyhow I'll leave
it here just in case.
You can do the following: check out
22114b7a6ada54c4c66a9b5705a2c2233046a61f,
take graphs/generators/classical_geometries.py and remove the top part
before the first def.
Now join the result to the bottom of graphs/generators/families.py
Now you can look at the diff of the resulting
graphs/generators/families.py and
graphs/generators/families.py from the appropriate beta.
You will see all what happened at 22114b7a6ada54c4c66a9b5705a2c2233046a61f
this way.
After that you can review the diff of the ticket branch against
22114b7a6ada54c4c66a9b5705a2c2233046a61f.
--
Ticket URL: <http://trac.sagemath.org/ticket/19136#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
