#19136: NO and NU graphs
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  dimpase                |       Status:  needs_review
           Type:         |    Milestone:  sage-6.9
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  Nathann Cohen
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:  Dima   |  dbc50b1b074afe22f4fb32542e8b1ca76c41525e
  Pasechnik              |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/dimpase/NONU         |
   Dependencies:         |
  #19098, #19180         |
-------------------------+-------------------------------------------------

Comment (by ncohen):

 Yo,

 > no, read the code: in some cases eigenvalues aren't even computed;

 Depends how you see it. If you compute eigenvalues in several functions
 that could be merged, that you compute them too many times. If it were
 only one function, it wouldn't be the case.

 > because several ifs suck and make code unreadable and harder to debug,
 and hard to document and test. Imagine e.g. how hard it would be to figure
 out what doctest tests what.

 While you were developing it perhaps, but there is nothing to debug now,
 right?

--
Ticket URL: <http://trac.sagemath.org/ticket/19136#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to