#19136: NO and NU graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: Dima | 79ce567d62ac693b0abe28b659cde2e16abdeb09
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/NONU |
Dependencies: |
#19098, #19180 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Hellooooooo,
> > - Remove the commented code that your functions contain
>
> hmm, where? I've better worded a comment that looked as code, but
otherwise...
{{{
(tmp|✔)~/sage/graphs$ grep "^# " strongly_regular_db.pyx
# -*- coding: utf-8 -*-
# print "ev: ", r, " ", s, "\n"
# print "p=", p, " t=", t, " r=", r, " s=", s,"\n"
# print "2nd try: p=", p, " t=", t, " r=", r, " s=", s,"\n"
# print "q=", q, "e=", e, "\n"
# n = t/kk + 2
# print q**(n-1)*(q**n - e)/(q + 1), " ",\
# (q**(n-1) + e)*(q**(n-2) - e), " ",\
# q**(2*n-5)*(q+1) - e*q**(n-2)*(q-1) - 2, " ",\
# q**(n-3)*(q + 1)*(q**(n-2) - e),"\n"
}}}
> > - Why 5 `is_NO*` functions instead of one `is_NO` ? I remember a
comment of
> > yours about copy/paste...
>
> it's because the arithmetic properties of parameters are quite different
in each of these
> cases. Each has a different algorithm coded.
So the test is different in each case, but the tests for prime powers, the
ordering or `s,r`, the eigenvalues.. All this is common (not to mention a
big part of the doc). Why not one function, with several 'if' for each
case?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19136#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
