#19226: some (collinearity graphs of) GQ(q-1,q+1)
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: Dima | b5a2fcd90050e59021aef77f1a803aaeb65f4c55
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/GQ |
Dependencies: |
#19136 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
In [comment:10]:
> Please do not use GQ anywhere which is not a mathematical notation, e.g.
neither in
> paragraphs of documentation nor in the constructor's name.
Also,
{{{
+ if hyperoval is None:
+ O = filter(lambda x: x[1]+x[2]*x[3]==0 or (x[1]==1 and x[2]==0
and x[3]==0), Pi)
+ O = set(O)
+ else:
+ map(lambda x: x.set_immutable(), hyperoval)
+ O = set(hyperoval)
+
+ if check_hyperoval and (not hyperoval is None):
}}}
I read:
{{{
if A:
...
else:
...
if (not A):
...
}}}
Could you change it into:
{{{
if hyperoval is None:
...
else:
...
if check_hyperoval:
...
}}}
Then it should be good to go,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19226#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
