#19661: the srgs from Cossidente and Penttila construction of hemisystems in
H(3,q^2)
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_review
Type: | Milestone: sage-7.0
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 7c0aac76d2b66a2d481773dae7e0e7b2177cd6be
Report Upstream: N/A | Stopgaps:
Branch: |
public/19661b |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yo,
> I don't actually know how to deal with creating an exception from a
libgap function returning `fail`.
If you start the GAP function without the package installed, I think
you'll get an exception.
> It can be converted to Sage's `bool` just fine, and the previous version
(in public/19661 branch) did `bool(libgap.LoadPackage(...))` and raised
an exception based on its result. I don't know the rationale behind this
changed to using `is_package_installed`.
Because that's how it is done everywhere else. I don't care much about the
'if', I just thought that it would make sense to say "install this
package" right after having checked that the package was installed.
> I can install a GAP package directly into SAGE_LOCAL, and this would
work with `libgap.LoadPackage(...)`, but won't work with
`is_package_installed`.
> The fact that GRAPE lives in `gap_packages` at present is an unimportant
detail, and might change; what's important is that the corresponding GAP
functionality is available, and GAP surely knows better than Sage about
it.
I agree with whatever you just said, but in your original branch the error
message was 'install gap_package', and that does not work at all with the
case where the guy installed his own version of gap. Once you are set on
which situations you want to deal with please change the exception to
whatever you like.
The only thing is that if you want to advise the user to install
'gap_package', please do it with `PackageNotFoundError` for it generates
the appropriate message automatically.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19661#comment:58>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
