#19259: subrings of the symbolic ring
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Daniel Krenn | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/behackl/symbolics/symbolic- | c4a0e226b7fa34959d990be3bb768d270fd7f9a5
subring | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by behackl):
* commit: 581f3157f57c8b38390cf515e065cf62eacec306 =>
c4a0e226b7fa34959d990be3bb768d270fd7f9a5
* branch: u/dkrenn/symbolic-subring => u/behackl/symbolics/symbolic-
subring
Comment:
Thanks, this resolves these two issues.
Besides some minor changes to the code and documentation, I noticed that
the `merge` methods for the functors were doing the wrong thing:
- merging two accepting functors should give an accepting functor with the
intersection of the variables,
- merging two rejecting functors should give a rejecting functor with the
union of the variables,
- when merging a rejecting and an accepting functor, the result has to to
be an accepting functor with all accepted variables, but without the
rejected ones.
I adapted the code accordingly.
In principle, this would be a `positive_review` from my side, however, I'd
like to rewrite your code some more such that subrings of subrings can be
constructed as well. The easiest way to do so (probably), is to let the
functors do everything.
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=7938d95efbba4282216166d9ba200e1552a9b21f
7938d95]||{{{module description of subring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=852959a8bec1f6da8c5a2f0d69edb8b23b9d0c59
852959a]||{{{rename only_constants --> no_variables}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e4837e9b4f2e9edff62ae0bb192a406c44cba561
e4837e9]||{{{correct parent of result of an_element}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ff99c7f211725817f213257d2edfad01acfabdc2
ff99c7f]||{{{Trac #19259: change to has_valid_variable}}}||
||[http://git.sagemath.org/sage.git/commit/?id=581f3157f57c8b38390cf515e065cf62eacec306
581f315]||{{{Trac #19259: check validity of variables}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c9b24288c1222beb5d436fedd9cda144d89b10b4
c9b2428]||{{{improve language}}}||
||[http://git.sagemath.org/sage.git/commit/?id=05dc8345c3cc09a083bd588366793149daa1d6ab
05dc834]||{{{misc. changes, indentation, line breaks}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8cc884a527e7d72fe125509c8f1cfa556ee83773
8cc884a]||{{{fix merge of functors}}}||
||[http://git.sagemath.org/sage.git/commit/?id=aeae8f3358607c5081e72470b66672765e42ecb3
aeae8f3]||{{{Merge tag '7.0' into symbolics/symbolic-subring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c4a0e226b7fa34959d990be3bb768d270fd7f9a5
c4a0e22]||{{{merge accepting and rejecting functors in all cases}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19259#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
