#19259: subrings of the symbolic ring
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Daniel Krenn | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/behackl/symbolics/symbolic- | c4a0e226b7fa34959d990be3bb768d270fd7f9a5
subring | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by dkrenn):
Replying to [comment:18 behackl]:
> Besides some minor changes to the code and documentation,
Cross-review of the minor things positive, but ...
> I noticed that the `merge` methods for the functors were doing the wrong
thing:
> - merging two accepting functors should give an accepting functor with
the intersection of the variables,
> - merging two rejecting functors should give a rejecting functor with
the union of the variables,
> - when merging a rejecting and an accepting functor, the result has to
to be an accepting functor with all accepted variables, but without the
rejected ones.
No, `merge` is correct. Composition means creating a larger subring, which
contains both the corresonding rings (it is used in pushout).
So please `git revert`
>
||[http://git.sagemath.org/sage.git/commit/?id=8cc884a527e7d72fe125509c8f1cfa556ee83773
8cc884a]||{{{fix merge of functors}}}||
and
>
||[http://git.sagemath.org/sage.git/commit/?id=c4a0e226b7fa34959d990be3bb768d270fd7f9a5
c4a0e22]||{{{merge accepting and rejecting functors in all cases}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19259#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
