#19259: subrings of the symbolic ring
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  symbolics          |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Daniel Krenn       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/behackl/symbolics/symbolic-      |  d376b1022bc5f7aa5b8ffbb422cfe0bfa0d951d5
  subring                            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by behackl):

 Replying to [comment:20 dkrenn]:
 > No, `merge` is correct. Composition means creating a larger subring,
 which contains both the corresonding rings (it is used in pushout).
 > So please `git revert`

 Done. I thought of composition instead of something that is used in the
 construction of the pushout, sorry.

 My approach requires an implemented compoisiton of functors; I'll take
 care of that in a follow-up ticket.

 As you have reviewed my changes, I'll set this to `positive_review` after
 building and checking the documentation again.

--
Ticket URL: <http://trac.sagemath.org/ticket/19259#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to