#19586: Add is_cayley_graph
-------------------------------------+-------------------------------------
       Reporter:  jaanos             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  graph theory       |   Resolution:
       Keywords:  Cayley graphs      |    Merged in:
  groups                             |    Reviewers:  Nathann Cohen
        Authors:  Janoš Vidali       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  95e34eecb315bcd0fded9c4f02a22b8c85e0ca1f
  u/jaanos/add_is_cayley_graph       |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hellooooooo,

 > True, but the `\` in line 20891 of `generic_graph.py` is actually
 outside any parentheses.

 Sigh... Right. You write extremely clean code, y'know?

 I re-read everything and added a couple of 'default values' for the
 arguments in the INPUT section, in a commit at public/19586. You can
 change the branch's name on this ticket if you agree with it.

 Dima? Could you please review the code of `_regular_subgroup_gap`? I
 reviewed everything else but I'm not knowledgeable for that.

 If this part is good for you, then this ticket can be changed to
 `positive_review`.

 THaaaaaaaaaaaaanks,

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19586#comment:69>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to