#20028: sorting of number field elements
-------------------------------------+-------------------------------------
Reporter: cremona | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.1
Component: number fields | Resolution:
Keywords: sort number field | Merged in:
elements | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/cremona/20028 | ae87261971f6ddc93d1d40c24c3a141be58457bd
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by cremona):
Replying to [comment:26 bhutz]:
> Also commenting on the projective_morphism code line 3002-3014 as I
helped review that: Except for the unused list variable rem_indices this
code is doing exactly what is it supposed to:
>
> Given a list of periodic points get rid of any that have period less
than n, i.e., if you want the minimal 4 periodic points, go through and
remove the fixed points and the 2 periodic points.
>
> Hence the variable j is walking through the iterates (up to n) of each
point indexed by i. Since the list is traversed in reverse order, the pop
doesn't break it. I'm not saying that there isn't a better way to do this,
but the code does do its intended task. Perhaps some additional code
comments are in order there so that people can more easily decipher it.
Ben, I can only apologise again for doubting the code hen I just
misunderstood it (and specifically what self(P) did). At some point when
this ticket is finished, perhaps adding some comments and removing the
redundant line would be a good idea, but there is no hurry. (Feel free to
open a ticket for that already.)
--
Ticket URL: <http://trac.sagemath.org/ticket/20028#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
