#20028: sorting of number field elements
-------------------------------------+-------------------------------------
Reporter: cremona | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.1
Component: number fields | Resolution:
Keywords: sort number field | Merged in:
elements | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/cremona/20028 | 2016dd34852bbdae2bac70e66451bed830753f10
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by cremona):
Replying to [comment:31 cremona]:
> Thanks, that does help clarify what is happening. I'll keep in the
try/except here since otherwise (as you say) a vast number of other
changes would be needed. I think that the half dozen other places where
we added try/except around sort attempts will not be so problematical.
I have almost finished this, and it was not so hard. A few doctests
relied on the list of solutions to some equations and these now need
sorted() in the doctest since thesolutions are not automatically sorted.
Apart from that, there were several places where lack of sorting of real &
complex roots of a polynomial led to permuting the real and complex
embeddings of a number field; this was easy to fix since now the functions
K.real_mebeddings() and K.complex_embeddings() use the sorting in RR and
CC to sort themselves, which dealt with all such problems. (In the
elliptic curve period lattice code which has a ridiculous number of
doctests, by me, I made the test more consistent by always using the above
functions instead of sometimes using K.embeddings(RR) and
K.embeddings(CC), since K.embeddingss() does not sort).
Two problems remain, only. (1) the file
src/sage/tests/french_book/mpoly.py where I was not sure of the etiquette
of changing doctest input/output since presumably the book text might need
changng too. (2) one failing test in
src/sage/schemes/elliptic_curves/ell_point.py and two in
src/sage/schemes/elliptic_curves/period_lattice.py are causd by a seprate
bug which previously struck me in ticket #18336 *which is still not
resolved* (see there for what I am talking about). If we can fix that
then both this ticket and that one could be finished off.
The new commit is uploaded.
>
> I hope that after this work is done we'll be able to convince others
that the change is worth doing!
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=2016dd34852bbdae2bac70e66451bed830753f10
2016dd3]||{{{#20028: most doctests now pass}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20028#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
