#20111: Cleaning of subword complex code
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-7.1
      Component:  combinatorics      |   Resolution:
       Keywords:  subword complex    |    Merged in:
        Authors:  Christian Stump    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/stumpc5/cleaning_of_subword_complex_code|  
924a4d9bfabe1ff54ed348d151332cb751e1f554
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by stumpc5):

 The diff is a pain -- I had to interchange the appearance of the classes
 {{{SubwordComplex}}} and {{{SubwordComplexFacet}}} in the file in order to
 write {{{Element = SubwordComplexFacet}}} into the {{{SubwordComplex}}}
 class.

 So what did I change:

 * the the init of subword complex
 * added the {{{__classcall__}}} method to make parents unique
 * tiny changes to make the input a tuple instead of a list (this also
 forced changes in multiple other places such as {{{Q.reverse}}} or in the
 function definition of the cython file.

 Once the above issue is solved, this is ready for review.

--
Ticket URL: <http://trac.sagemath.org/ticket/20111#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to