#20111: Cleaning of subword complex code
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: subword complex | Merged in:
Authors: Christian Stump | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/stumpc5/cleaning_of_subword_complex_code|
8b742258c1ab075eca3f2a134bfe962064fddb04
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by stumpc5):
Replying to [comment:7 tscrim]:
> - Could you add a `TestSuite(SC).run()` (possibly skipping tests)?
This is already done in the tests inside {{{__init__}}}. Or do you mean
something else?
> - Instead of `__call__`, you should be able to use
`_element_constructor_`. By doing this, it fits into Sage's coercion
framework (although I guess that doesn't quite apply here [yet]) and you
shouldn't have to do `hasattr(F,"parent") and F.parent() is self`.
If I do that, the class inherits the {{{__call__}}} from simplicial
complexes, which then results {{{SC([0,1])}}} to not return an element
class element but a list. What is appropriate then here?
--
Ticket URL: <http://trac.sagemath.org/ticket/20111#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
