#20111: Cleaning of subword complex code
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: subword complex | Merged in:
Authors: Christian Stump | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/stumpc5/cleaning_of_subword_complex_code|
8b742258c1ab075eca3f2a134bfe962064fddb04
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Some comments:
- Could you add some doctests to `__classcall__` (good tests include
checking the uniqueness against different input types)?
- Could you add a `TestSuite(SC).run()` (possibly skipping tests)?
- The `SubwordComplex.__eq__` is redundant (and slower) than that given by
`UniqueRepresentation`.
- Instead of `__call__`, you should be able to use
`_element_constructor_`. By doing this, it fits into Sage's coercion
framework (although I guess that doesn't quite apply here [yet]) and you
shouldn't have to do `hasattr(F,"parent") and F.parent() is self`.
I can also work on this over the weekend.
--
Ticket URL: <http://trac.sagemath.org/ticket/20111#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
