#20111: Cleaning of subword complex code
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: subword complex | Merged in:
Authors: Christian Stump | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/cleaning_subword_complex_code-20111|
e8ad2a99028c1253f419da22ece556885730f3ec
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
* branch: u/stumpc5/cleaning_of_subword_complex_code =>
public/combinat/cleaning_subword_complex_code-20111
* commit: 81171d70abef0b87443f89b40627b0b0ec10ac71 =>
e8ad2a99028c1253f419da22ece556885730f3ec
Comment:
Replying to [comment:8 stumpc5]:
> Replying to [comment:7 tscrim]:
> > - Could you add a `TestSuite(SC).run()` (possibly skipping tests)?
>
> This is already done in the tests inside {{{__init__}}}. Or do you mean
something else?
Ah, sorry, I missed that.
> > - Instead of `__call__`, you should be able to use
`_element_constructor_`. By doing this, it fits into Sage's coercion
framework (although I guess that doesn't quite apply here [yet]) and you
shouldn't have to do `hasattr(F,"parent") and F.parent() is self`.
>
> If I do that, the class inherits the {{{__call__}}} from simplicial
complexes, which then results {{{SC([0,1])}}} to not return an element
class element but a list. What is appropriate then here?
I guess we can just leave it for now.
I pushed some changes that fix the failing doctests and do a few tweaks to
the Cython file. If you agree with my changes, then you can set a positive
review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=190e8d2dd4d29b202c77fc2de5d58e9fda01f6c6
190e8d2]||{{{Merge branch 'u/stumpc5/cleaning_of_subword_complex_code' of
trac.sagemath.org:sage into
public/combinat/cleaning_subword_complex_code-20111}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e8ad2a99028c1253f419da22ece556885730f3ec
e8ad2a9]||{{{Fixing doctest errors and some cython tweaks.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20111#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
