#20693: Sage crashes when inverting/dividing large number field elements
-------------------------------------+-------------------------------------
Reporter: ehlen | Owner:
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-7.3
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Stephan Ehlen, | Reviewers:
Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 162035995bff5bb15d73bc13d2994655f24a8c23
u/pbruin/20693-sage_crashes_when_computing_newforms| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ehlen):
@pbruin I can remove the doctest.
What I really miss in sage is some more unit tests that would check many
many cases and maybe even some random cases to work that should be
separate from the doctests but this should be discussed elsewhere.
If you agree that simplifying {{{_div_()}}} makes sense, I could push both
changes at any time.
(I made some randomized tests and I don't see a performance advantage of
the currently duplicated code versus the suggested simplification.)
Also, did you check very carefully that removing those additional
multiplications that used to be done in {{{_invert_c()}}} do not cause any
trouble anywhere? I wonder how someone could even come up with this....
could it really be that there was really no reason at all for this???
(This is exactly why I think there should be (even) more (complex) testing
in sage.)
Maybe we should ask the author Joel B. Mohler? However, I don't see
activity by him on the github repo and the code has been sitting there
since 2009... It seems really trivial to remove it and I can't find any
problems but it just seems so hard for me to believe that someone did such
a complicated thing without any reason ;-)
--
Ticket URL: <http://trac.sagemath.org/ticket/20693#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
