#20973: Cartan type Aoo
-------------------------------------+-------------------------------------
Reporter: andrew.mathas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: Cartan type, A | Merged in:
infinity |
Authors: Andrew Mathas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/andrew.mathas/cartan_type_aoo | 3c5370673410e49fc0acbff86d1ba443c72a44a8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:20 andrew.mathas]:
> I have addressed all of the comments above. Given the ambiguity between
`oo` and `+oo` I have used `NN` and `ZZ` throughout, although `oo` is a
synonym for `ZZ`:
That is exactly what I was just going to suggest this morning. :P I think
this is the best way forward.
> There is now a `CartanType_standard` class in `cartan_type.py` but, to
be honest, it does not save a great deal. I played round a little to try
and rationalise the code but everything seems very tangled because small
changes in one place cause errors elsewhere. I think that if the code is
to the cleaned up then it needs to be done by some one who is more
familiar with it and its' applications in sage.
Yea, I remember them being fairly interconnected, sometimes in subtle
ways. I remember fighting some things when I was trying to implement
hyperbolic types (which I don't know when I will get back to this).
> The code works with 7.3.beta7 but it will almost certainly not merge on
the next release on the develop branch given trac:18555.
If #18555 really does cause a conflict, which I agree it probably does,
then let's have a preemptive strike and base this over #18555.
--
Ticket URL: <https://trac.sagemath.org/ticket/20973#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
